Skip to content

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Jun 9, 2025

Linked Issues

Description

Fixes the variation fallback - if there's no default variation then it'll use the first available variation.

Difficulties that exist in the chartdata but are missing in metadata for that variation now appear in the difficulty toolbox. They aren't added to the metadata, however.

Screenshots/Videos

2025-06-09.21-28-58.mp4

@Lasercar Lasercar changed the base branch from main to develop June 9, 2025 11:36
@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Jun 9, 2025
@Lasercar Lasercar marked this pull request as draft June 9, 2025 11:38
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from 441fed5 to f8c518f Compare June 9, 2025 11:42
@Lasercar Lasercar marked this pull request as ready for review June 9, 2025 11:56
@Lasercar
Copy link
Contributor Author

Lasercar commented Jun 9, 2025

One thing of note, since this adds missing chartdata difficulties to the metadata difficulties for that variation, this means that stuff like picospeaker will show up in the difficulties, and it'll be saved as a playable difficulty?

I think instead I'll just make it add the difficulties to the difficulty toolbox instead, and later, I can add a button to add/remove said difficulty from the metadata, and add some kind of visual in the metadata toolbox.

Until that stuff, there'll be a few cases I'm sure of someone complaining why their difficulty shows up in the chart editor but not in freeplay or whatever, because the chart editor does not indicate that the difficulty isn't in the metadata.

@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch 2 times, most recently from 1b295aa to 0e68bbf Compare June 9, 2025 12:55
@Lasercar Lasercar changed the title [BUGFIX] Chart Editor - Variation fallback & add missing chartdata difficulties to metadata [BUGFIX] Chart Editor - Variation fallback & add chartdata only difficulties to difficulty toolbox Jun 9, 2025
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. labels Jun 9, 2025
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from 0e68bbf to 346515e Compare June 11, 2025 03:17
@Lasercar Lasercar changed the title [BUGFIX] Chart Editor - Variation fallback & add chartdata only difficulties to difficulty toolbox [BUGFIX] Chart Editor - Variation fallback & chartdata only difficulties in difficulty toolbox Jun 11, 2025
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from 346515e to 30f6bb9 Compare June 17, 2025 11:52
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from 30f6bb9 to b4d0951 Compare July 22, 2025 14:08
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from b4d0951 to eda8e8a Compare August 3, 2025 11:12
@Lasercar Lasercar force-pushed the bugfix/chart-editor-add-missing-chartdata-difficulties-to-metadata branch from eda8e8a to de9e60c Compare September 27, 2025 07:07
@Lasercar
Copy link
Contributor Author

It's time

@Lasercar Lasercar changed the title [BUGFIX] Chart Editor - Variation fallback & chartdata only difficulties in difficulty toolbox [BUGFIX] Chart Editor - Variation fallback Sep 27, 2025
@Lasercar Lasercar changed the base branch from develop to main September 27, 2025 07:08
@Lasercar Lasercar changed the base branch from main to develop September 27, 2025 07:08
@Hundrec
Copy link
Member

Hundrec commented Sep 27, 2025

The name of the PR confuses me
What's the actual purpose of this PR now that variations do seem to fall back properly?
Is it about making Pico's chart accessible in Stress, for example?

@Lasercar
Copy link
Contributor Author

Lasercar commented Sep 27, 2025

The name of the PR confuses me What's the actual purpose of this PR now that variations do seem to fall back properly? Is it about making Pico's chart accessible in Stress, for example?

No, that's the new draft pull request. This is just the variation fallback now. Didn't make much sense to use this branch for the new stuff anyway.

Basically, this is just hopefully fixing a few edge cases where the main variation of a song isn't called default

@Hundrec Hundrec changed the title [BUGFIX] Chart Editor - Variation fallback [BUGFIX] Properly fall back to first available variation in Chart Editor Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Development

Successfully merging this pull request may close these issues.

3 participants