-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[BUGFIX] Properly fall back to first available variation in Chart Editor #5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
441fed5
to
f8c518f
Compare
One thing of note, since this adds missing chartdata difficulties to the metadata difficulties for that variation, this means that stuff like I think instead I'll just make it add the difficulties to the difficulty toolbox instead, and later, I can add a button to add/remove said difficulty from the metadata, and add some kind of visual in the metadata toolbox. Until that stuff, there'll be a few cases I'm sure of someone complaining why their difficulty shows up in the chart editor but not in freeplay or whatever, because the chart editor does not indicate that the difficulty isn't in the metadata. |
1b295aa
to
0e68bbf
Compare
0e68bbf
to
346515e
Compare
346515e
to
30f6bb9
Compare
30f6bb9
to
b4d0951
Compare
b4d0951
to
eda8e8a
Compare
eda8e8a
to
de9e60c
Compare
It's time |
The name of the PR confuses me |
No, that's the new draft pull request. This is just the variation fallback now. Didn't make much sense to use this branch for the new stuff anyway. Basically, this is just hopefully fixing a few edge cases where the main variation of a song isn't called default |
Linked Issues
Description
Fixes the variation fallback - if there's no default variation then it'll use the first available variation.
Difficulties that exist in the chartdata but are missing in metadata for that variation now appear in the difficulty toolbox. They aren't added to the metadata, however.
Screenshots/Videos
2025-06-09.21-28-58.mp4